Enable option to allow all values for workload dashboard #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other workload dashboards already allow for the include-all option. Having this options makes the workload dashboard a way better default dashboard than the current `Kubernetes / Compute Resources / Namespace (Pods)` dashboard since it's basically the same, but with the advantage to also more easily filter for specific workloads inside the namespace. Signed-off-by: Stefan Andres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other workload dashboards already allow for the include-all option.
Having this options makes the workload dashboard a better "default" dashboard than the current
Kubernetes / Compute Resources / Namespace (Pods)dashboard, since it's basically the same, but with the advantage to allow for more easily filtering of specific workloads inside the namespace.Let me know if there was a reason to not do that.
I've tried to patch our local generation of the dashboards and I was successful in patching the dashboard wit libsonnet, but I would also need to patch the queries and this would leave more technical debt to keep the queries up to date than is technical feasible.